search

boostorg / histogram

Fast multi-dimensional generalized histogram with convenient interface for C++14
Boost Software License 1.0
315 stars 73 forks source link

Cmake tests should be prefixed with ${PROJECT_NAME} and Python should be optional #261

Closed HDembinski closed 4 years ago

HDembinski commented 4 years ago

pdimov Today at 3:36 AM @hdembinski at https://github.com/boostorg/histogram/blob/develop/test/CMakeLists.txt#L9, you have a test that is not prefixed with ${PROJECT_NAME}, not a good practice

The Python tests should only execute when Python is available. Need something like

find_package(PythonInterpreter)
if (PYTHON_FOUND)
  add_test(....)
endif()