search

boostorg / icl

Boost.org icl module
http://boost.org/libs/icl
10 stars 44 forks source link

icl/iterator.hpp and icl/detail/element_iterator.hpp include <boost/config/warning_disable.hpp> #29

Open pgroke-dt opened 3 years ago

pgroke-dt commented 3 years ago

icl\iterator.hpp and icl\detail\element_iterator.hpp include <boost/config/warning_disable.hpp>. This disabled the MSVC warning C4996 without re-enabling it again.

For context: C4996 is MSVC's warning for using deprecated stuff. This means code that uses Boost.Icl will not get warning C4996 which IMO is quite bad. <boost/config/warning_disable.hpp> even contains the following comment:

//  IT SHOULD NOT BE INCLUDED BY ANY BOOST HEADER.
//
//  YOU SHOULD NOT INCLUDE IT IF YOU CAN REASONABLY FIX THE WARNING.
brunom commented 2 years ago

Still broken in 1.78