search

boostorg / locale

Boost.Locale
Boost Software License 1.0
31 stars 70 forks source link

Revert iconv check executable related changes #106

Closed TheSalvator closed 2 years ago

TheSalvator commented 2 years ago

fixes #63

grafikrobot commented 2 years ago

This looks good to me.

Flamefire commented 2 years ago

Thanks for this! After discussion in Slack with @grafikrobot I created #107 which also fixes a similar issue with the ICU check. I also improved the naming and added comments on why the obj rule is required.

I'd suspect that the issue is only there when you pass ICONV_PATH, i.e. when you need an additional include path. Is that correct?

TheSalvator commented 2 years ago

@Flamefire Yep you can see it in here https://c3i.jfrog.io/c3i/misc/logs/pr/12807/5-configs/macos-clang/boost/1.80.0//6dce47697105e9cab74f0925ce72b345cce34916-build.txt

ICONV_PATH=/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/libiconv/1.17/_/_/package/0aa7be2d0914b6f3128105e305c90b9cb0cae86d

Closing this one in favor of #107

Flamefire commented 2 years ago

I see thanks! Were you able to test #107 ? I don't have any system to actually test this and the Github OSX runners all have the iconv stuff in libc so the issue isn't reproducible there and hence I can't verify the fix.

TheSalvator commented 2 years ago

I see thanks! Were you able to test #107 ? I don't have any system to actually test this and the Github OSX runners all have the iconv stuff in libc so the issue isn't reproducible there and hence I can't verify the fix.

Not yet, but today i'll do it)