boostorg / locale

Boost.Locale
Boost Software License 1.0
31 stars 70 forks source link

Update ICU configuration from Boost.Regex #120

Closed Flamefire closed 1 year ago

Flamefire commented 1 year ago

Use the same mechanism for getting the ICU configuration as Boost.Regex does.

Error on use of ICU_LINK or ICU_LINK_LOCALE now that we have proper support.

Closes #70 as the work of @SSE4 is integrated here
Fixes #55

/cc @grafikrobot

TODO: Check that the omission of <dll-path> doesn't break anything.

codecov[bot] commented 1 year ago

Codecov Report

Merging #120 (cf79b51) into develop (6a9248b) will not change coverage. The diff coverage is n/a.

:exclamation: Current head cf79b51 differs from pull request most recent head bf0e7db. Consider uploading reports for the commit bf0e7db to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/boostorg/locale/pull/120/graphs/tree.svg?width=650&height=150&src=pr&token=vF6mWvgGUn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://codecov.io/gh/boostorg/locale/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #120 +/- ## ======================================== Coverage 88.46% 88.46% ======================================== Files 100 100 Lines 8982 8982 ======================================== Hits 7946 7946 Misses 1036 1036 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/boostorg/locale/pull/120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/boostorg/locale/pull/120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [6a9248b...bf0e7db](https://codecov.io/gh/boostorg/locale/pull/120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).
Flamefire commented 1 year ago

@grafikrobot I'm unsure about the last commit Make icu-path non-local

Is this the correct way? Without it the variable is not set in the path_options rule and I wasn't able to find information about local/scopes in B2

grafikrobot commented 1 year ago

@grafikrobot I'm unsure about the last commit Make icu-path non-local

Is this the correct way? Without it the variable is not set in the path_options rule and I wasn't able to find information about local/scopes in B2

That's correct. The local var only lasts as long as the evaluated scope of the jamfile. And since it's evaluated once. And afterwards the rule is called the var is gone. One convention we do use is to prefix module global variables with a period ("."). I.e. .icu-path = .... To designate that they are actually private vars.