Closed Flamefire closed 1 year ago
Document the meaning of the utf8_support enum and refactor/change usages to be consistent and logical. Add comments where required.
utf8_support
utf8_support::native
native_with_wide
native
native_without_wide
Closes #171
@artyom-beilis Please do a quick check that I didn't miss anything or misunderstood something you wrote in #171
I added few comments. :-)
:-)
Merging #173 (ac05f1d) into develop (aa58a42) will increase coverage by 0.37%. The diff coverage is 100.00%.
0.37%
100.00%
Document the meaning of the
utf8_support
enum and refactor/change usages to be consistent and logical.Add comments where required.
utf8_support::native
which is only checked for but never setnative_with_wide
tonative
after that is now free for use. This makes the meaning clear as there is nonative_without_wide
.utf8_support
for this which was confusingCloses #171
@artyom-beilis Please do a quick check that I didn't miss anything or misunderstood something you wrote in #171