boostorg / locale

Boost.Locale
Boost Software License 1.0
31 stars 70 forks source link

Add support for modular build structure. #234

Closed grafikrobot closed 1 week ago

grafikrobot commented 1 month ago

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

grafikrobot commented 2 weeks ago

Please review and merge this PR at your earliest convenience.

Flamefire commented 1 week ago

@grafikrobot I rebased your branch to remove the sync commits without any changes.

I then fixed the dynamic build as <link>shared:<define>BOOST_LOCALE_DYN_LINK=1 was missing from the usage-requirements, see https://github.com/boostorg/locale/pull/234/commits/3ff8e5a3f029b125f5d286957f979fc71f264cde

Can you verify the current state please?

Is it possible to have keyword arguments for lib in B2 and add the common-requirements there too which currently only exist for project? That would reduce the duplication and avoid the above issue. It also removes the current practice of commenting what the arguments to lib mean.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.76%. Comparing base (84d91b3) to head (3ff8e5a). Report is 11 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/boostorg/locale/pull/234/graphs/tree.svg?width=650&height=150&src=pr&token=vF6mWvgGUn&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://app.codecov.io/gh/boostorg/locale/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #234 +/- ## ======================================== Coverage 95.76% 95.76% ======================================== Files 116 116 Lines 10035 10035 ======================================== Hits 9610 9610 Misses 425 425 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/boostorg/locale/pull/234?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/boostorg/locale/pull/234?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [84d91b3...3ff8e5a](https://app.codecov.io/gh/boostorg/locale/pull/234?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).