Closed grafikrobot closed 1 week ago
Please review and merge this PR at your earliest convenience.
@grafikrobot I rebased your branch to remove the sync commits without any changes.
I then fixed the dynamic build as <link>shared:<define>BOOST_LOCALE_DYN_LINK=1
was missing from the usage-requirements, see https://github.com/boostorg/locale/pull/234/commits/3ff8e5a3f029b125f5d286957f979fc71f264cde
Can you verify the current state please?
Is it possible to have keyword arguments for lib
in B2 and add the common-requirements
there too which currently only exist for project
? That would reduce the duplication and avoid the above issue. It also removes the current practice of commenting what the arguments to lib
mean.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.76%. Comparing base (
84d91b3
) to head (3ff8e5a
). Report is 11 commits behind head on develop.
This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.
This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:
This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.