I built Boost 1.72 with GCC 7.5 with added -Wextra in cxxflags. Problems are still in current code:
./boost/locale/utf.hpp:224:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
./boost/locale/utf.hpp:231:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
libs/locale/src/util/gregorian.cpp:206:27: warning: this statement may fall through [-Wimplicit-fallthrough=]
libs/locale/src/util/gregorian.cpp:505:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
libs/locale/src/util/gregorian.cpp:529:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
libs/locale/src/util/gregorian.cpp:725:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
I may be mistaken, but looks Boost has BOOST_FALLTHROUGH for this purpose.
Flamefire
commented
1 year ago
I built Boost 1.72 with GCC 7.5 with added -Wextra in cxxflags. Problems are still in current code:
./boost/locale/utf.hpp:224:17: warning: this statement may fall through [-Wimplicit-fallthrough=] ./boost/locale/utf.hpp:231:17: warning: this statement may fall through [-Wimplicit-fallthrough=] libs/locale/src/util/gregorian.cpp:206:27: warning: this statement may fall through [-Wimplicit-fallthrough=] libs/locale/src/util/gregorian.cpp:505:21: warning: this statement may fall through [-Wimplicit-fallthrough=] libs/locale/src/util/gregorian.cpp:529:21: warning: this statement may fall through [-Wimplicit-fallthrough=] libs/locale/src/util/gregorian.cpp:725:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
I may be mistaken, but looks Boost has
BOOST_FALLTHROUGHfor this purpose.Related: #26
Misspellings:
libs/locale/src/util/gregorian.cpp:206 throght libs/locale/src/util/gregorian.cpp:234 indecator