Added initial implementation of move_if_noexcept

boostorg / move

Boost.org move module

http://boost.org/libs/move

Boost Software License 1.0

20 stars 52 forks source link

Added initial implementation of move_if_noexcept #1

Closed apolukhin closed 10 years ago

apolukhin commented 10 years ago

This is an implementation of move_if_noexcept .

Tests work well GCC in C++11 and C++03. Also checked move_if_noexcept with tests of Boost.CircularBuffer - works OK on GCC in C++11 and C++03 modes.

Questions:

Is it OK to include <boost/move/traits.hpp> in <boost/move/utility.hpp> ?
I'm not sure about BOOST_MOVE_OLD_RVALUE_REF_BINDING_RULES part. Could you please take a closer look at it?

igaztanaga commented 10 years ago

This seems a good addition. It makes utilities.hpp header a bit heavy now that it needs to include type traits to implement move_if_noexcept but that could be ironed splitting that header in the future. I'll merge and push it ASAP, probably this week. Many thanks for the patch.

apolukhin commented 10 years ago

Any progress? Can I help somehow?

igaztanaga commented 10 years ago

El 12/08/2014 18:43, Antony Polukhin escribió:

Any progress? Can I help somehow?

Sorry Antony, I missed this with the Boost 1.56 sprint and ongoin holidays. I promise to work on this soon.

Thanks.

Ion

igaztanaga commented 10 years ago

I've merged and made some changes in commit SHA-1: 3c56780e0e67b8f16339cce5a4899b861801f031

A bug in MSVC-12.0 has delayed the merge but all seems working in MSVC-7.1-12.0, GCC and Clang.

Thanks for the great work.