search

boostorg / move

Boost.org move module
http://boost.org/libs/move
Boost Software License 1.0
19 stars 55 forks source link

Workaround for bogus [-Wignored-attributes] warning on GCC 6.x/7.x #14

Closed pgroke-dt closed 6 years ago

pgroke-dt commented 6 years ago

I've executed the Boost.Move and Boost.Container tests with GCC 6.3 & MSVC 2017 => pass.

I've also verified the general "technique" (wrapping the struct with the alignment attribute in another struct) with several GCC, ICC and Clang versions, and it seems to work fine - i.e. no bugs where the compiler "loses" the alignment for the wrapper struct or the wrapper struct comes out with an unexpected size.

So I guess this should be safe.

igaztanaga commented 6 years ago

Retested locally for several GCC and MSVC versions, looks fine. Many thanks for the patch!

pgroke-dt commented 6 years ago

You're welcome! Thanks for re-testing and merging :)