search

boostorg / move

Boost.org move module
http://boost.org/libs/move
Boost Software License 1.0
19 stars 55 forks source link

Disabling forceinline with Clang broke the build #50

Closed alandefreitas closed 1 year ago

alandefreitas commented 1 year ago

https://github.com/alandefreitas/url/actions/runs/4737166802/jobs/8410131446 broke the build.

Lots of errors like:

./boost/move/utility_core.hpp:290:7: error: 'BOOST_MOVE_FORCEINLINE' does not name a type
       BOOST_MOVE_FORCEINLINE T&& move_if_not_lvalue_reference(typename ::boost::move_detail::remove_reference<T>::type& t) BOOST_NOEXCEPT
       ^

It looks like the commit https://github.com/boostorg/move/commit/a6cdf134d09f705ba8762c7e9d5e2490cfdcce8d simply removed BOOST_MOVE_FORCEINLINE instead of defining it as empty but didn't stop using it in other files.

Here's an example: https://github.com/alandefreitas/url/actions/runs/4737166802/jobs/8410131446

igaztanaga commented 1 year ago

It looks that my local regression didn't have clang enabled. Many thanks for the quick report.

igaztanaga commented 1 year ago

It seems that regression tests in clang are working again:

https://github.com/boostorg/move/actions/runs/4739821058/jobs/8415005405