search

boostorg / mpl

Boost.org mpl module
http://boost.org/libs/mpl
Boost Software License 1.0
52 stars 78 forks source link

Fix -Wparentheses warning not ignored on NVCC #62

Closed aladram closed 2 years ago

aladram commented 2 years ago

BOOST_GCC is not defined for NVCC, therefore we should use BOOST_GCC_VERSION.

aladram commented 2 years ago

@mclow could you please look at the Windows CI results? Failure seems to come from a package missing from the msys repo (pacman 5.2.1-12). This change only affects GCC + NVCC. Thanks!

aladram commented 2 years ago

@eldiener any chance you could look at this PR when you have some time? Thanks!

codecov[bot] commented 2 years ago

Codecov Report

Merging #62 (b076018) into develop (c61b1e3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #62   +/-   ##
========================================
  Coverage    94.73%   94.73%           
========================================
  Files            5        5           
  Lines           19       19           
========================================
  Hits            18       18           
  Misses           1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c61b1e3...b076018. Read the comment docs.

jeking3 commented 2 years ago

CI failure is known and tracked by #50