search

boostorg / mpl

Boost.org mpl module
http://boost.org/libs/mpl
Boost Software License 1.0
52 stars 78 forks source link

Fix BOOST_MPL_AUX_ASSERT_NOT_NA #73

Open aihao1007 opened 2 years ago

mclow commented 2 years ago

This looks reasonable to me. Are there any tests that are currently failing that this will fix? If not, should there be?

aihao1007 commented 2 years ago

BOOST_MPL_AUX_ASSERT_NOT_NA macro parameters is "x" ,"type" is undefined.

mclow commented 2 years ago

BOOST_MPL_AUX_ASSERT_NOT_NA macro parameters is "x" ,"type" is undefined.

I'm not disagreeing; I'm wondering how this is failing.

aihao1007 commented 2 years ago

When I use BOOST_MPL_AUX_ASSERT_NOT_NA alone to wirte a test code,I discover this error. However, the macro is right when is uesd by the mpl to define "type".

codecov[bot] commented 2 years ago

Codecov Report

Merging #73 (b27b650) into develop (db09fb1) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/boostorg/mpl/pull/73/graphs/tree.svg?width=650&height=150&src=pr&token=31bBblRchG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://codecov.io/gh/boostorg/mpl/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #73 +/- ## ======================================== Coverage 94.73% 94.73% ======================================== Files 5 5 Lines 19 19 ======================================== Hits 18 18 Misses 1 1 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/boostorg/mpl/pull/73?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/boostorg/mpl/pull/73?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [db09fb1...b27b650](https://codecov.io/gh/boostorg/mpl/pull/73?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).