Closed ckormanyos closed 6 months ago
It's green-ish with CodeCov upload error (re-running) and 1 timeout on drone.
Hi @jzmaddock do you think the potential fix in this PR is sufficient?
Cc: @mborland
I'll take a look shortly.
That's fine, a simpler fix is:
if (arg > 0)
return floor(arg);
return ceil(arg);
which doesn't then require a temporary.
That's fine, a simpler fix is:
Thank you John. It is now cycling in CI.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
878138a
) 94.1% compared to head (29ca08c
) 84.6%.
Hi Matt (@mborland) in Multiprecision, uploading Coverage from suite number 1 takes too long and times out all the time, or a lot of the time. We need to eventually look into this.
I can help when we both have a time slot for this...
Cc: @jzmaddock
In math every test suite gets its own coverage run because just doing suite 1 and suite 2 also had issues with timeouts. Porting that logic is likely the easiest way to solve this.
every test suite gets its own coverage run
I appreciate that. Many thanks @mborland
The purpose of this PR is to provide a minimalistic fix to #586.
In that issue, we see a phenomenon that may require conversion to number-wrap or non-wrapped type detected in overloads of
trunc
andlltrunc
.If no better fix is found in this releasce cycle, then this does the trick.
Cc: @jzmaddock John take a look if you find better...
Cc: @mborland Standalone with/without the presence of
Math
.Cc: @radj307