search

boostorg / multiprecision

Boost.Multiprecision
Boost Software License 1.0
188 stars 112 forks source link

Add CodeCov badge for develop #596

Closed ckormanyos closed 5 months ago

ckormanyos commented 5 months ago

Hi @jzmaddock and @mborland I hope you like this as much as I do. I would like quick access and clear visibility for the CodeCov achievements on the front cover ReadMe.

Can we do this? Do we really need table entries for develop/master? Or should i make a separate viewing area for a single CodeCov badge?

ckormanyos commented 5 months ago

It looks like the following on the page.

grafik

mborland commented 5 months ago

I would do one for develop and one for master. Release is in a few weeks so they will both be populated shortly. John is pushing hard on improving math coverage so I think it makes sense to show the delta between the two during the development period. Charconv is shown below:

image

ckormanyos commented 5 months ago

The badge(s) are in.

I also added a (admittedly somewhat subjectively selected) section on Using Multiprecision, which I personally would find helpful. It also links to GodBolt.

Like/Disapprove/Don't-Care about the new section? We can retain or modify or delete accordingly. Comments?

Cc: @jzmaddock and @mborland

mborland commented 5 months ago

The badge(s) are in.

I also added a (admittedly somewhat subjectively selected) section on Using Multiprecision, which I personally would find helpful. It also links to GodBolt.

Like/Disapprove/Don't-Care about the new section? We can retain or modify or delete accordingly. Comments?

I can see it being a useful addition.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de24099) 94.1% compared to head (46988e4) 94.1%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/boostorg/multiprecision/pull/596/graphs/tree.svg?width=650&height=150&src=pr&token=SDDBym7Pc9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://app.codecov.io/gh/boostorg/multiprecision/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #596 +/- ## ======================================= Coverage 94.1% 94.1% ======================================= Files 273 273 Lines 28525 28525 ======================================= Hits 26834 26834 Misses 1691 1691 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/boostorg/multiprecision/pull/596?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/boostorg/multiprecision/pull/596?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [de24099...46988e4](https://app.codecov.io/gh/boostorg/multiprecision/pull/596?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).