Closed Baduit closed 2 months ago
Looks good!
Please see the comments to make the header changes smaller. Also some docs updates are required
I updated my PR according to your comments.
But on the github action I see a failure that I don't understand https://github.com/Baduit/pfr/actions/runs/9660279058/job/26645491447
I updated my branch and thanks to your commit to fix the CI the builds are green
Totals | |
---|---|
Change from base Build 10537504895: | 0.0% |
Covered Lines: | 405 |
Relevant Lines: | 405 |
Many thanks for the PR!
Add a new function
for_each_field_with_name
The goal is to be able to do this:
I think this is more user friendly than we way it can be done without this PR:
I tried to make the code of
for_each_field_with_name
as close as possible tofor_each_field
.I will add new tests if you think this feature could be merged in the future.
I have explored a bit the idea of completing
for_each_field
instead of creating a new function in this branch https://github.com/Baduit/pfr/tree/feature/for_each_field_can_provide_name, most of the work is done and it makes possible to do stuff like this:Do you think it is a better idea ?