boostorg / phoenix

Boost.org phoenix module
http://boost.org/libs/phoenix
30 stars 46 forks source link

Use proto subscript and assignment overload operators buildins #64

Closed Kojoley closed 6 years ago

Kojoley commented 6 years ago

Fixes #62.

djowel commented 6 years ago

Oh no... IIRC there's a reason why we have those instead of the builtins. I have to jog my memory though. @sithhell , do you remember?

Kojoley commented 6 years ago

I was also feeling it is here for a reason, but failed to find one, then I gave it a try and it works, also fixing an issue...

djowel commented 6 years ago

I was also feeling it is here for a reason, but failed to find one, then I gave it a try and it works, also fixing an issue...

I may be wrong. It's been a while since I looked at the code.

Kojoley commented 6 years ago

With this patch actor definition is closer to what one can find in proto's lambda example.

djowel commented 6 years ago

I'm good with it as long as all the tests pass. The concern might be no longer relevant.

Flast commented 6 years ago

OK