search

boostorg / program_options

Boost.org program_options module
http://boost.org/libs/program_options
110 stars 107 forks source link

Changes for Embarcadero C++ clang-based compilers, targeting Boost 1.74 #94

Closed eldiener closed 4 years ago

eldiener commented 4 years ago

A code coverage check failed with:

+lcov --version

lcov: LCOV version 1.14-6-g40580cd

+lcov --gcov-tool=gcov-7 --rc lcov_branch_coverage=1 --base-directory /home/travis/build/boostorg/boost-root/libs/program_options --directory /home/travis/build/boostorg/boost-root --capture --output-file all.info

Capturing coverage data from /home/travis/build/boostorg/boost-root

Can't locate PerlIO/gzip.pm in @INC (you may need to install the PerlIO::gzip module) (@INC contains: /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /usr/local/bin/geninfo line 62.

BEGIN failed--compilation aborted at /usr/local/bin/geninfo line 62.

This has nothing to with this PR. Can this please be merged ?

pdimov commented 4 years ago

The change from abort to std::abort seems wrong; std::abort is defined in <ctsdlib>, whereas <stdlib.h>, which is being included, defines abort.

codecov[bot] commented 4 years ago

Codecov Report

Merging #94 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #94   +/-   ##
========================================
  Coverage    49.89%   49.89%           
========================================
  Files           23       23           
  Lines         1385     1385           
  Branches       707      707           
========================================
  Hits           691      691           
- Misses         110      111    +1     
+ Partials       584      583    -1
Impacted Files Coverage Δ
src/cmdline.cpp 45.51% <ø> (ø)
src/convert.cpp 65.62% <ø> (ø)
src/parsers.cpp 45.61% <ø> (ø)
src/options_description.cpp 48.26% <0.00%> (-0.39%) :arrow_down:
...de/boost/program_options/detail/value_semantic.hpp 43.75% <0.00%> (+1.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a237942...e9d423c. Read the comment docs.