search

boostorg / property_tree

Boost.org property_tree module
http://boost.org/libs/property_tree
55 stars 92 forks source link

Remove empty destructors (redundant since C++11) #104

Closed ecatmur closed 9 months ago

ecatmur commented 1 year ago

The compiler-generated copy constructor and copy assignment operator are deprecated since C++11 on classes with user-declared destructors.

The compiler-generated destructor is noexcept since C++11, so there is no need to declare/define a user-provided or explicitly defaulted destructor.

This change allows clean compilation with the -Wdeprecated-copy-dtor/-Wdeprecated-copy-with-user-provided-dtor flag.

ashtum commented 9 months ago

@ecatmur I believe we don't need BOOST_DEFAULTED_FUNCTION macro anymore, since we have dropped C++03 support. Could you please update this PR accordingly so that we can merge it.

ashtum commented 9 months ago

@pdimov Could you please approve the workflow?