search

boostorg / property_tree

Boost.org property_tree module
http://boost.org/libs/property_tree
55 stars 93 forks source link

Account for character class being char or unsigned char. #22

Closed saturnjct closed 11 months ago

saturnjct commented 8 years ago

Avoid comparing to <= 0xFF and triggering a GCC warning. See https://svn.boost.org/trac/boost/ticket/5598

LRFLEW commented 8 years ago

Perhaps you should also add signed char to that, since it is considered a separate type from char.

ashtum commented 11 months ago

@pdimov, it seems that this issue existed in earlier versions of GCC. I was unable to replicate it using any compiler except GCC 4.1.2: https://godbolt.org/z/W4e6e5hdT Considering that create_escapes is a templated function, I assume that receiving no warning is the expected behavior which has been fixed in later versions of GCC. Do you think this is still worth fixing?

pdimov commented 11 months ago

Link to ticket for reference: http://trac.cpp.al/trac10/ticket/5598

pdimov commented 11 months ago

No, I don't think we need to care about GCC 4.1 at this point. The minimum supported version in Boost today is 4.8.