search

boostorg / python

Boost.org python module
http://boostorg.github.io/python
Boost Software License 1.0
468 stars 201 forks source link

Use the /python//numpy target instead of [ numpy.include ] (fixes #361) #362

Closed pdimov closed 3 years ago

pdimov commented 3 years ago

This fixes issue #361 by using the /python//numpy target. It however requires the corresponding Boost.Build PR https://github.com/boostorg/build/pull/726 to be merged first.

SoapGentoo commented 3 years ago

I've verified that this patch works with multiple python implementations, please merge it.

thesamesam commented 3 years ago

As per my comment on the linked PR for the other side in Build, this resolves my issue.

stefanseefeld commented 3 years ago

@pdimov , can you please confirm that it's now safe to (re-)merge this PR to devel (so I can merge everything to master before the upcoming deadline) ?

pdimov commented 3 years ago

I can see the change on b2's master branch (https://github.com/boostorg/build/blob/d52f1993d906aa3fd3649a8dd5134402794bf86e/src/tools/python.jam#L1055-L1057), so this should now work. (cc @grafikrobot)

stefanseefeld commented 3 years ago

Thanks, I have re-added your commit, and will merge to master before Wednesday.

pdimov commented 3 years ago

Reminder that it's Wednesday. :-)