Replace include of outdated boost/cast.hpp header

Mike-Devel commented 3 years ago

Instead include boost/polymorphic_cast.hpp directly.
This replaces the dependency of Boost.Range on Boost.NumericConversion with a direct dependency on Boost.Conversion (on which it anyway depends transitively via Boost.Iterator

Mike-Devel commented 3 years ago

Ping. Btw.: the test failure on mac is already present on develop and master and thus I don't beleive this PR has anything to do with it.

Mike-Devel commented 3 years ago

Food for thought:

It seems the only reason this is included at all is the use of polymorphic_downcast here:

https://github.com/boostorg/range/blob/486c74fbeba9ee9975e6d68e974230ec8ec22fb0/include/boost/range/detail/any_iterator_wrapper.hpp#L28

Looking at the implementation of polymorphic_downcast:

https://github.com/boostorg/conversion/blob/9540be42b4fa1ea66ae850f233e3ddff45e9efeb/include/boost/polymorphic_cast.hpp#L97-L102

you could probably just as well inline the two lines of code and get rid of the dependency completely, but I didn't know this is something desireable for you. The PR as it is just cuts out a deprecated header out of the dependency chain, without changing the code.

Mike-Devel commented 3 years ago

Thanks

boostorg / range

Replace include of outdated boost/cast.hpp header #117