boostorg / release-tools

5 stars 24 forks source link

From version 1.70 and onwards, .7z archvies no longer use Windows line endings #32

Open SigmundVik opened 2 years ago

SigmundVik commented 2 years ago

The documentation states: "Distribution files with extensions .zip and .7z use Windows line endings."

Starting with version 1.70, this is no longer the case. Either the documentation should get updated to reflect this change, or the line endings in the .7z (and .zip) archives should follow the documentation.

(I would prefer the latter, since I can then choose what line endings I want based on which archive I download.)

sdarwin commented 2 years ago

Investigating the history of the bug.
March 4, 2019: https://github.com/boostorg/boost/commit/2887df330be901b57b7c2774e868ac8b2e55d270 Before the commit these scripts were run:

    - exec "${HOME}/script.sh" test_pre:
    - exec "${HOME}/script.sh" test_override:
    - exec "${HOME}/script.sh" test_post:

After the commit, one script executes:

ci_boost_release.py test_override

test_pre should probably be reinstated. Include in https://github.com/boostorg/boost/blob/master/.circleci/config.yml

      - run: '[ "$CIRCLE_NODE_INDEX" != "0" ] || EOL=LF python3 ${HOME}/ci_boost_release.py test_pre'
      - run: '[ "$CIRCLE_NODE_INDEX" != "1" ] || EOL=CRLF python3 ${HOME}/ci_boost_release.py test_pre'