search

boostorg / spirit

Boost.org spirit module
http://boost.org/libs/spirit
393 stars 161 forks source link

Global shadowing warnings #730

Open ibis-hdl opened 2 years ago

ibis-hdl commented 2 years ago

Using MSVC with enabled Warning /W4 I get the warning on Boost 1.78

H:.conan\short\8c1894\1\include\boost\spirit\home\x3\auxiliary\any_parser.hpp(121): warning C4459: Declaration of "attr" hides global Declaration H:.conan\short\8c1894\1\include\boost\spirit\home\x3\auxiliary\attr.hpp(126): note: see Declaration of "boost::spirit::x3::attr"

H:.conan\short\8c1894\1\include\boost\spirit\home\x3\support\no_case.hpp(56): warning C4459: Declaration of "char_type" hides global Declaration H:.conan\short\8c1894\1\include\boost\spirit\home\x3\char\char.hpp(20): note: see Declaration of "boost::spirit::x3::standard::char_type"

I haven't checked it with v1.80 yet. Please fix the naming so once is able to compile with higher warning levels on MSVC; otherwise close this issue please.

Kojoley commented 2 years ago

Fixing global shadowing warnings is on my TODO, but at very low priority due to little value and high intrusiveness of the fix.