search

boostorg / spirit

Boost.org spirit module
http://boost.org/libs/spirit
383 stars 159 forks source link

X3: Cover position_tagged's features with test #739

Open denzor200 opened 1 year ago

Kojoley commented 1 year ago

Is there any particular reason for this? I'm pretty sure it is tested indirectly via error handler tests,

I don't have time to deal with CI currently, maybe next week. Probably CI checksout master branch for superrepo on pull requests.

denzor200 commented 1 year ago

I'm pretty sure it is tested indirectly via error handler tests,

I haven't found any references to x3::position_cache in the tests.

Is there any particular reason for this?

position_cache's internals will be patched in https://github.com/boostorg/spirit/issues/698

Kojoley commented 1 year ago

I'm pretty sure it is tested indirectly via error handler tests,

I haven't found any references to x3::position_cache in the tests.

https://github.com/boostorg/spirit/blob/e30073e5bebb8102c73d1ad3588bf3f68cec2b64/include/boost/spirit/home/x3/support/utility/error_reporting.hpp#L73

denzor200 commented 1 year ago

I just looked error handler tests. I can't find any test case when x3::error_handler used with parsing into x3::position_tagged attribute. Is it exists?

denzor200 commented 1 year ago

PR updated. Added test case for x3::error_handler with x3::position_tagged, test case for x3::position_cache was deleted.