boostorg / stacktrace

C++ library for storing and printing backtraces.
https://boost.org/libs/stacktrace
422 stars 70 forks source link

Add freestanding from_dump() function for reducing scopes and less ty… #101

Closed leha-bot closed 3 years ago

leha-bot commented 3 years ago

…ping

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.4%) to 92.688% when pulling 9fc7459e6794c382339d79df1c6e9d1718dc7be1 on leha-bot:freestanding_from_dump_factory_fn into e75d2ff93bbe63ed3f1f578823cae6b8039da821 on boostorg:develop.

apolukhin commented 3 years ago

Sorry, but I'm closing this PR.

Infield experience shows that the dump/load functions of the Boost.Stacktrace library are badly designed and provoke users to do bad things (like use them in signal handlers).

Your PR is good, but it makes simpler to use those bad functions.