boostorg / stacktrace

C++ library for storing and printing backtraces.
https://boost.org/libs/stacktrace
424 stars 71 forks source link

Add support for modular build structure. #172

Closed grafikrobot closed 2 weeks ago

grafikrobot commented 1 month ago

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

grafikrobot commented 1 month ago

Please review and merge this PR at your earliest convenience.

apolukhin commented 3 weeks ago

@grafikrobot could you please take another look at this PR. Something is wrong with CI runs. I've failed to quickly diagnose the problem, may be your experience would find the issue quickly?

grafikrobot commented 2 weeks ago

@grafikrobot could you please take another look at this PR. Something is wrong with CI runs. I've failed to quickly diagnose the problem, may be your experience would find the issue quickly?

Figured out the problem. I had inadvertently added /boost/stacktrace//boost_stacktrace as a dependency for all the tests. Which made the linker choose the noop version instead of the specific one each test wants. Should be resolved now.

coveralls commented 2 weeks ago

Coverage Status

coverage: 86.35%. remained the same when pulling 7f2966289a11c0d05fe922971b27f3b58a1d6980 on grafikrobot:modular into cbf0df774dd7baa2af5a7d28662fd58b90ea8c3d on boostorg:develop.