Closed Kojoley closed 5 years ago
That's macro naming is... confusing. Also, MSYS2 which is Cygwin has GetUserDefaultUILanguage
in my case, change Cygwin check to !defined(__CYGWIN__) || defined(__MSYS__)
?
I don't think __MSYS__
matters. I have GetUserDefaultUILanguage
everywhere - in Cygwin, Cygwin 64, MinGW-w64, MinGW 32. These checks seem outdated.
For Cygwin it seems outdated for 19 years https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=48ba505b8bc8671c7a2b243c816bf6f5b4451291, for MinGW-w64 7-12 years, I am not sure about MinGW. Should I remove them and leave only !BOOST_PLAT_WINDOWS_RUNTIME
?
Yes. Appveyor has all these so if it complains, we'll put them back in, but I doubt it.
__MINGW32__
- any MinGW__MINGW64__
- MinGW-w64 in 64 bit mode__MINGW64_VERSION_MAJOR
- MinGW-w64 in both 64 and 32 bit modes