boostorg / system

Boost.org system module

http://boost.org/libs/system

35 stars 86 forks source link

Wrong null character stripping for FormatMessage #41

Closed Kojoley closed 5 years ago

Kojoley commented 5 years ago

FormatMessage

If the function succeeds, the return value is the number of TCHARs stored in the output buffer, excluding the terminating null character.

WideCharToMultiByte

cchWideChar

If this parameter is -1, the function processes the entire input string, including the terminating null character. Therefore, the resulting character string has a terminating null character, and the length returned by the function includes this character.

pdimov commented 5 years ago

Thanks, could you please split the test changes from the .hpp changes into two separate commits, I want to apply the test one first and run the tests while still keeping you as the commit author.

Kojoley commented 5 years ago

Commits or PRs? If commits, in what order?

pdimov commented 5 years ago

Commits, test first, fix second.

Kojoley commented 5 years ago

Please restart the build on the first commit. Travis seems to auto-cancel it because of settings.

pdimov commented 5 years ago

Applied manually, thanks.