search

boostorg / system

Boost.org system module
http://boost.org/libs/system
36 stars 85 forks source link

there is no warning number '4351' #96

Closed marakew closed 1 year ago

marakew commented 1 year ago

https://github.com/boostorg/system/blob/9a6d79b84147854aa919644b56b8553f5a2bedb8/include/boost/system/detail/error_category.hpp#L53

MSVC seems unsupport this warning

iam use MSVC 19/ 14.29.30133 cl.exe Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30146 for x64 with -std:c++20

so i got

boost/system/detail/error_category.hpp(53): warning C4619: #pragma warning: there is no warning number '4351'

pdimov commented 1 year ago

I can't reproduce this. I'm trying the following program

#include <boost/system.hpp>
#include <iostream>

int main()
{
    std::cout << _MSC_FULL_VER << std::endl;
}

under VS 2019, and there's no warning. (The output is 192930146, so it's the same version of the compiler.)

marakew commented 1 year ago

yes i have the same _MSC_FULL_VER output let me do small research about warning

marakew commented 1 year ago

iam enable many warning for cl.exe so with /w14619 i got - there is no warning number '4351'

pdimov commented 1 year ago

Yes, it looks like 4619 is disabled by default. There's another warning, 4616, for warning numbers that are even more invalid. :-)

It seems that warning 4351 has been removed in VS 2015 and later, so I'll disable it only for earlier versions.

marakew commented 1 year ago

ok will wait fix in upstream

pdimov commented 1 year ago

Should be fixed with https://github.com/boostorg/system/commit/7ae6b317f3325bf722773ba7e5855c37811b3388.

marakew commented 1 year ago

i mean at master of boost https://github.com/boostorg/boost/tree/master/libs system @ 9a6d79b 8 days ago still not update

pdimov commented 1 year ago

Yes, I will update master as well, once CI passes on develop.

marakew commented 1 year ago

it seems ok, can be close issue