search

boostorg / test

The reference C++ unit testing framework (TDD, xUnit, C++03/11/14/17)
http://boost.org/libs/test
Boost Software License 1.0
183 stars 140 forks source link

Remove ::boost::test_tools::tt_detail::dummy_cond #348

Closed jspam closed 1 month ago

jspam commented 2 years ago

Replace loops using it by simple do { ... } while (0) loops. This allows static analysis tools like clang-tidy to better understand the code and avoid false positives.

Fixes #343.

mborland commented 1 month ago

I spent the better part of several days fighting clang-tidy false positives caused by this.

Can this change please be merged for the next boost release?

I merge in develop to kick off a CI run to validate. The changes look like they should be OK.