search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
203 stars 162 forks source link

Loop executor: Don't poll but wait in loop() + test enhanchment. #118

Closed Oberon00 closed 7 years ago

Oberon00 commented 7 years ago

Fixes #117.

Oberon00 commented 7 years ago

I should mention that I only did a b2 ts_ on my Windows 10 x64 MSVC 14 2015 platform to confirm that the updated test passes for me, but that's all.

Oberon00 commented 7 years ago

Oh, I just see that the test seems to work just by chance because unless I'm mistaken ~serial_executor fails do ensure that "The completion of all the closures happen before the completion of the executor destructor. " (docs). It seems to just call close(). Sorry, I missed the scoped_thread member. Works fine as documented 👍

viboes commented 7 years ago

Thanks for the PR