search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
203 stars 162 forks source link

on_tls_prepare is broken under VS2017 #119

Closed pravic closed 7 years ago

pravic commented 7 years ago

Fixed in bd0379af57fa294df310221492da618844182658, but introduced in 206ff0ba7c8aba742222a341f7eba6571a392097.

So, Boost 1.63 and 1.62 are broken now. I wonder what was the reason to introduce such check and maintain it for every new compiler version?

viboes commented 7 years ago

Why do you say that this version were broken? It is not clear to know what the new version would provide .

BTW, you now now a fix for the new compiler version :)

pravic commented 7 years ago

Because that check against _MSC_VER 1900 was introduced 9 months ago, so it was included in 1.62 and 1.63. Broken for VS 2017, of course.

Yes, now we have a fix, but we have to wait until 1.64 (until August?) to receive VS 2017 support. Especially because such checks exist in other boost libraries too.

It is not clear to know what the new version would provide .

Oh please, how many bugs were introduced by new compiler versions? Isn't easier to fix them instead of increment supported versions each release?

MarcelRaad commented 7 years ago

The bad thing that I don't understand is that some future version with (_MSC_VER > 2000) will be broken again.

pravic commented 7 years ago

instead of increment supported versions each release?

Well, except just to increment supported compiler versions, we need do not forget about it: #11365 appeared in 1.58 version, but was fixed only in 1.61.

viboes commented 7 years ago

I'm maintaining as well as I can Boost.Thread. I have no idea of Windows. If some one has a solution, please propose it, post a PR. To all of you that are interested. Please comment the PR.

I've requested help on Boost.Thread maintenance for windows several times already. If some one want to maintain this part of Boost, or even more please contact me directly.

MarcelRaad commented 7 years ago

@viboes

I'm maintaining as well as I can Boost.Thread.

Thanks for that!

If some one has a solution, please propose it, post a PR.

I've posted a PR to just remove the never used codepath to avoid confusion and future breakage: https://github.com/boostorg/thread/pull/120

viboes commented 7 years ago

Thanks, I will merge it once the release 1.64 is delivered.

pravic commented 7 years ago

Was it merged? Looks like no.

MarcelRaad commented 7 years ago

@pravic Yes, into the develop branch.

viboes commented 7 years ago

https://github.com/boostorg/thread/pull/120