Closed Lastique closed 7 years ago
Thanks for this PR. I can not test it. Hoping that everything that work now will continue to work I will merge it. We could rollback if it introduce some regressions.
You can see the test results on the regression page:
http://www.boost.org/development/tests/develop/developer/thread.html
Currently, most MinGW testers fail because of this bug like this:
In file included from ../boost/thread/condition_variable.hpp:14:0,
from ../boost/thread/future.hpp:20,
from ..\libs\thread\test\sync\futures\async\async_executor_pass.cpp:28:
../boost/thread/win32/condition_variable.hpp: In instantiation of 'bool boost::detail::basic_condition_variable::do_wait(lock_type&, boost::detail::timeout) [with lock_type = boost::unique_lock<boost::mutex>]':
../boost/thread/win32/condition_variable.hpp:332:50: required from here
../boost/thread/win32/condition_variable.hpp:233:67: error: no matching function for call to 'boost::detail::basic_condition_variable::entry_manager::entry_manager(boost::detail::basic_condition_variable::entry_ptr, boost::mutex&)'
In my local tests on MinGW the problem was fixed with this PR.
What about the other platforms and compilers?
This is a Windows-only change. I did not test MSVC, but I'm pretty sure it should be fine.
I was thinking in Windows. Antony has promise to test it tome. We will see on the regression test also.
Thanks.
It seems this is working well.
Thanks again, Vicente
This resolves compilation failures with MinGW.