search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
203 stars 162 forks source link

- switch to boost winapi, to avoid duplicated definitions when compil… #140

Closed SSE4 closed 7 years ago

SSE4 commented 7 years ago

…ing using Clang on Windows

139

viboes commented 7 years ago

Andrey, could you check this PR using WinApi?

Lastique commented 7 years ago

Sorry, @viboes, I didn't receive a notification. I did a quick check and there is an include missing. I'm running the checks again now and will create a PR to this PR to fix it.

Lastique commented 7 years ago

Here's the PR with my fixes: https://github.com/SSE4/thread/pull/1.

viboes commented 7 years ago

Andrey, if I understand you approve this PR.

Lastique commented 7 years ago

My limited testing did not reveal errors and I'm generally in favor of porting to Boost.WinAPI, so you could say so. IMHO, you can merge it rather safely and then watch the test results.

viboes commented 7 years ago

I'm confident on your testing.

viboes commented 7 years ago

There is an additional issue on Windows that maybe it can be managed by the move to WinAPI.

https://svn.boost.org/trac10/ticket/12323

Please, could you take a look?

Lastique commented 7 years ago

That issue is unrelated to the move. AFAICS, that piece of code unconditionally includes windows.h, I see no reason to change that. I'll create a separate PR for that ticket.