Switching the Windows condition_variable and interruptible_wait functions over to using internal_timespec_clock.

boostorg / thread

Boost.org thread module

http://boost.org/libs/thread

200 stars 161 forks source link

Switching the Windows condition_variable and interruptible_wait functions over to using internal_timespec_clock. #166

Closed austin-beer closed 6 years ago

austin-beer commented 6 years ago

I ended up getting to this sooner than I'd planned.

Here are the results on Windows with this PR.

https://github.com/austin-beer/test-time-jumps/blob/master/windows_results_austin_no_generic_shared.txt https://github.com/austin-beer/test-time-jumps/blob/master/windows_results_austin_yes_generic_shared.txt

viboes commented 6 years ago

Wow, this is a really big change and a big simplification of the code :) I would need some time to digest all these change, in particular every thing concerning the windows changes.

I don't know why AppVeyor CI has not been launched on this PR.

viboes commented 6 years ago

I found the AppVeyor link https://ci.appveyor.com/project/viboes/thread/build/1.0.93-feature/timespec_clocks

Everything is Ok.

viboes commented 6 years ago

The windows report is impressive.

No more no-timeout,
generic shared_mutex and
future

are all ok :)

Only failing

some timed_mutex
some recursive_timed_mutex and
some shared_mutex

I'll not have too much time before the C++ standard meeting mailing list deadline (16 Oct). I will really appreciate if you can work on this.

BTW, I'm looking for a co-maintainer for Boost.Thread ;-)