search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
203 stars 162 forks source link

Added tests to check for lost notifications. #176

Closed austin-beer closed 7 years ago

austin-beer commented 7 years ago

I finally got some time to work on this again. Here are the tests I've put together for the lost notification issue. They fail with the current feature/timespec_clocks branch, but succeed with the current develop branch and with the fixes I've made in feature/timespec_clocks_pr14 (https://github.com/boostorg/thread/pull/170).

viboes commented 7 years ago

Austin, as I said to you, I'm busy until the 16h.

Hrr, the develop branch is broken again.

I'll see what I can do.

viboes commented 7 years ago

As this PR contains only test, I have decided to merge them and we will see. I'm confident you have done the tests, and if something don't works we will fix them.

viboes commented 7 years ago

I'll merge develop into time_spec branch. An then I will merge #170.

viboes commented 7 years ago

Hrr, I believe this was for develop branch :(

viboes commented 7 years ago

Austin, I've merged the thread develop branch into timespec_clocks. Hopping this will work on the CI.

If it is the case you will need to do the same, taking care of merging Boost.Build and Boost root as well :(

Unfortunately I did some changes in develop pthread condition_variable (check -> unlock_if_locked) that could raise some conflicts in your branch :(

Apologies for all this breaking changes.

viboes commented 7 years ago

It is working now https://travis-ci.org/boostorg/thread/builds/286391606 If you don't reach to do the update, I'll try to merge your PR myself and fix the possible issues.