search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
203 stars 162 forks source link

Cleanup #188

Closed austin-beer closed 7 years ago

austin-beer commented 7 years ago

These are a series of commits that been sitting in my local workspace for a couple of weeks now. I was going to wait until after I'd finished the win32 changes before submitting them, but I decided to go ahead and submit them now to get them out of the way.

See the commit log for the list of changes I made.

viboes commented 7 years ago

Great we start to see green run in windows :)

austin-beer commented 7 years ago

A few green runs, at least. :)

austin-beer commented 7 years ago

FYI, the 64-bit Windows builds are failing due the unit tests exceeding the 260 character filepath limit on Windows. Every filepath includes \msvc-14.1\debug\address-model-64\threadapi-win32\threading-multi. Do you know if there is an easy way to shorten this? On the 32-bit builds the filepaths don't have \address-model-64 which is just enough to keep them under the 260 character limit so they don't fail.

viboes commented 7 years ago

Thanks for the info. /threadapi-win32 was added in order to do cross compiling.

No I don't know how to shorten them.

Could you create a issue for Boost.Build with the specific compiler report?

viboes commented 7 years ago

Steven Watanabe said on Boost ML " --abbreviate-paths

http://www.boost.org/build/doc/html/bbv2/reference/buildprocess.html#bbv2.reference.buildprocess.targetpath "

viboes commented 7 years ago

I've added --abbreviate-paths

austin-beer commented 7 years ago

--abbreviate-paths sounds like the solution we need. Thanks for adding that.

austin-beer commented 7 years ago

Glad to help. Which AppVeyor build are you looking at that's all green?