Fix final time jump issues

boostorg / thread

Boost.org thread module

http://boost.org/libs/thread

200 stars 161 forks source link

Fix final time jump issues #196

Closed austin-beer closed 6 years ago

austin-beer commented 6 years ago

The following implementations have been fixed:

include/boost/thread/win32/basic_timed_mutex.hpp
include/boost/thread/win32/basic_recursive_mutex.hpp
include/boost/thread/win32/shared_mutex.hpp
include/boost/thread/v2/shared_mutex.hpp

viboes commented 6 years ago

even if there are multiple issues with macos, I've merged it as you are unable to fix them.

viboes commented 6 years ago

I would like you to do a PR with the test you have. maybe a complete folder for these test would be the best.

austin-beer commented 6 years ago

It looks like all of the MAC OS test failures are due to not timing out when we should. My guess is there's an issue with how we're calculating or using the time on MAC OS.

I'll work on a PR to merge my test code into a folder in the Boost.Thread library. I probably won't get to it until after the holiday break, though.

viboes commented 6 years ago

I'll check my changes on the timespec for MacOs (but the test were ok after my change) and are ok in my MacOs :(

No problem. I will have a holiday break also.

BTW, thanks again.