search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
199 stars 161 forks source link

Simplify thread specific storage #238

Closed Kojoley closed 5 years ago

Kojoley commented 5 years ago

I have used shared_ptr for storing user data directly and custom destructor to handle user supplied destructor and lack of release on shared_ptr.

This can be further improved by replacing shared_ptr with local_shared_ptr.

Fixes #236.

viboes commented 5 years ago

What do you mean by "This can be further improved by replacing shared_ptr with local_shared_ptr."?

viboes commented 5 years ago

Please, could you describe what is the problem you are trying to fix, how have you fixed it and how do you probe that it has been fixed?

The PR is quite consequent. Do you believe that it could be possible to identify minor issues and minor fixes or refactorings that can be understood better?

Thanks anyway for your interest and working on those PR, really.

Kojoley commented 5 years ago

Closed and opened to restart travis

Kojoley commented 5 years ago

Nevermind, I found my solution worse than the current (it allocates on every reset), this could be fixed with shared_ptr aliasing, but I am not sure I want continue this.