Closed Kojoley closed 5 years ago
Hm, there is no boost macro to detect P0012R1, I think that it would be better to switch to decltype based detection.
Hi, have you checked on Windows? I see yet a lot of issues on the appVeyor.
The PR has nothing with issues on the Appveyor which are transient. You can try to solve them by adjusting tests timeout, running only two jobs simultaneously (appveyor gives a vm with two cores, but b2 is invoked with -j3
) or perform multiple tries before failing on those timing critical tests.
I'm wondering to remove those unstable test (depending on the time) from the regression tests and execute them only on machines I master.
On the other side I Would need to add tests that replace the real time and this needs a lot of work.
Traits does not handle
noexcept
qualifiers (which are part of function type in C++17) and wrongly did not detect methods. Because of this on MSVC 14.1 with -std=c++17boost::is_mutex_type<boost::mutex>::value
is false andboost::lock(mutex)
does not compile.Fixes #222.