search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
198 stars 162 forks source link

Most of the platform defintions in include/boost/thread/detail/platform.hpp are unused #255

Open jeking3 opened 5 years ago

jeking3 commented 5 years ago

Perhaps it would be a good idea to remove the unused definitions and switch to using Boost.Predef for detection where needed instead?

Example:

jking@ubuntu:~/boost/libs/thread$ grep -r AMIGAOS .
./include/boost/thread/detail/platform.hpp:#  define BOOST_THREAD_AMIGAOS
jking@ubuntu:~/boost/libs/thread$ grep -r THREAD_SOL .
./include/boost/thread/detail/platform.hpp:#  define BOOST_THREAD_SOLARIS
jking@ubuntu:~/boost/libs/thread$ grep -r THREAD_LINUX .
./include/boost/thread/detail/platform.hpp:#  define BOOST_THREAD_LINUX
jking@ubuntu:~/boost/libs/thread$ grep -r THREAD_BSD .
./include/boost/thread/detail/platform.hpp:#  define BOOST_THREAD_BSD
viboes commented 5 years ago

why not