boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
197 stars 162 forks source link

Avoid compiler warning about unused variable #382

Open mojca opened 1 year ago

mojca commented 1 year ago

When compiling in Visual Studio 2022 with "treat warnings as errors", I'm getting the following error which this PR should address. (The other option is to comment out the name.)

(I would be grateful if a fix could end up in 1.82.0.)

boost\libs\thread\src\win32\thread.cpp(580,236): error C2220: the following warning is treated as an error
boost\libs\thread\src\win32\thread.cpp(580,236): error C2220:             static inline BOOL WINAPI SetWaitableTimerEx_emulation(HANDLE hTimer, const LARGE_INTEGER *lpDueTime, LONG lPeriod, PTIMERAPCROUTINE pfnCompletionRoutine, LPVOID lpArgToCompletionRoutine, PREASON_CONTEXT WakeContext, ULONG TolerableDelay)
boost\libs\thread\src\win32\thread.cpp(580,236): error C2220:                                                                                                                                                                                                                                            ^
boost\libs\thread\src\win32\thread.cpp(580,236): warning C4100: 'TolerableDelay': unreferenced formal parameter
boost\libs\thread\src\win32\thread.cpp(580,217): warning C4100: 'WakeContext': unreferenced formal parameter
boost\libs\thread\src\win32\thread.cpp(580,217): warning C4100:             static inline BOOL WINAPI SetWaitableTimerEx_emulation(HANDLE hTimer, const LARGE_INTEGER *lpDueTime, LONG lPeriod, PTIMERAPCROUTINE pfnCompletionRoutine, LPVOID lpArgToCompletionRoutine, PREASON_CONTEXT WakeContext, ULONG TolerableDelay)
boost\libs\thread\src\win32\thread.cpp(580,217): warning C4100:                                                                                                                                                                                                                         ^
mojca commented 1 year ago

Is there any chance to review/merge this before the next Boost release?