search

boostorg / thread

Boost.org thread module
http://boost.org/libs/thread
197 stars 162 forks source link

Compilation error in future.hpp using LLVM upstream clang #402

Open thevinster opened 1 month ago

thevinster commented 1 month ago

After this patch in upstream LLVM, this line in future.hpp https://github.com/boostorg/thread/blob/aec18d337f41d8e3081ee65f5cf3b5090179ab0e/include/boost/thread/future.hpp#L4671 fails to compile with the following error

boost/boost/thread/future.hpp:4672:19: error: no member named 'that' in 'run_it<FutureExecutorContinuationSharedState>'; did you mean 'that_'?
 4672 |           that_=x.that;
      |                   ^
boost/boost/thread/future.hpp:4650:55: note: 'that_' declared here
 4650 |     shared_ptr<FutureExecutorContinuationSharedState> that_;
      |                                                       ^

From looking at the error and the code surrounding the error, is this a bug in future.hpp where the code should be using x.that_ given other nearby uses of x.that_?