search

boostorg / throw_exception

Common infrastructure for throwing exceptions
https://boost.org/libs/throw_exception
14 stars 46 forks source link

Replaced hardcoded symbol visibility for GCC with BOOST_SYMBOL_VISIBLE #10

Closed epvbergen closed 6 years ago

epvbergen commented 6 years ago

Possible fix for https://github.com/boostorg/throw_exception/issues/9. Any feedback? What tests would you want to see to validate this?

epvbergen commented 6 years ago

Note: using BOOST_SYMBOL_VISIBLE probably depends on PR #6 .

pdimov commented 6 years ago

Looks good but the convention throughout Boost seems to be class BOOST_SYMBOL_VISIBLE X, not BOOST_SYMBOL_VISIBLE class X.

It probably makes no difference but it doesn't hurt to be consistent.

pgroke-dt commented 6 years ago

If BOOST_SYMBOL_VISIBLE can expand to __declspec(dllexport) then class BOOST_SYMBOL_VISIBLE X is the only placement that will work.