search

boostorg / ublas

Boost.uBlas
https://www.boost.org/doc/libs/release/libs/numeric/ublas
111 stars 152 forks source link

Deprecated Inheritance From std::iterator Didn't Make It To Release #176

Open KurtAA42 opened 2 years ago

KurtAA42 commented 2 years ago

An UBLAS patch called: "Remove deprecated inheritance from std::iterator #97" didn't make it into the released version of Boost.

"std::iterator was deprecated in C++17 and removed in C++20. I replaced the inheritance with the 5 equivalent typedefs, even though they're not all used by ublas, for compatibility in case clients depend on them."

If I copy the file latest development version of the boost/numeric/ublas/detail/iterator.hpp into my boost directory it fixes the issue when building with VS 2019 C++20.

The fix was over 2 years ago and should have made it into Boost 1_75.

-Kurt

j2bbayle commented 12 months ago

Any updates on this?

Feels like this hack (adding back the deprecated and then removed std::iterator class) should be finally removed and the proposed fix (“Remove deprecated inheritance from std::iterator https://github.com/boostorg/ublas/pull/97”) included in the next upcoming release?

For users relying on C++17, lots of very irritating deprecation warnings appear when using ublas.

j2bbayle commented 11 months ago

Anyone?

Kojoley commented 6 months ago

@pdimov @glenfe ublas has not had a single merge from develop to master in 5 years.

glenfe commented 6 months ago

@Kojoley yes, I have complained about this before.

@bassoy Is uBLAS effectively unmaintained now? Do we need to find a new maintainer? If not, what is preventing a merge to master?

pdimov commented 6 months ago

What I remember from previous conversations on the matter is that the uBLAS team have their own ideas of how the develop and master branches need to work - develop requires C++20, whereas master still doesn't.

But if so, someone needs to take care of cherry-picking fixes from develop to master.

bassoy commented 6 months ago

@pdimov and @glenfe . We have developed a lot on the develop branch a lot of which is not merged to the master. We have made very good progress on the tensor development. Sorry

I will take now full responsibility and start to solve the issues.

bassoy commented 6 months ago

@pdimov and @glenfe . We have developed a lot on the develop branch a lot of which is not merged to the master. We have made very good progress on the tensor development. Sorry

I will take now full responsibility and start to solve the issues.

Pull request opened https://github.com/boostorg/ublas/pull/194.