search

boostorg / unordered

Boost.org unordered module
http://boost.org/libs/unordered
Boost Software License 1.0
63 stars 55 forks source link

Remove dependencies on Iterator, Detail #128

Closed cmazakas closed 2 years ago

cmazakas commented 2 years ago

Update test CML to include ConceptCheck as a dependency as it's no longer transitively included.

pdimov commented 2 years ago

Use conditional from type_traits instead of declaring this MSVC 6 if-then thing inline maybe?

pdimov commented 2 years ago

You shouldn't need the user-declared copy constructor and destructor of grouped_bucket_iterator. The compiler-generated ones should be fine.

pdimov commented 2 years ago

Same for grouped_local_bucket_iterator, including the copy assignment.

pdimov commented 2 years ago

Same for const_grouped_local_bucket_iterator.

pdimov commented 2 years ago

Same for iterator and c_iterator.

codecov[bot] commented 2 years ago

Codecov Report

Merging #128 (2417ede) into develop (1ed2a0a) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 2417ede differs from pull request most recent head 90b2536. Consider uploading reports for the commit 90b2536 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #128   +/-   ##
========================================
  Coverage    97.30%   97.30%           
========================================
  Files           73       73           
  Lines         9790     9883   +93     
========================================
+ Hits          9526     9617   +91     
- Misses         264      266    +2
Impacted Files Coverage Δ
test/helpers/random_values.hpp 100.00% <ø> (ø)
include/boost/unordered/detail/fca.hpp 99.31% <100.00%> (+0.11%) :arrow_up:
include/boost/unordered/detail/implementation.hpp 98.57% <100.00%> (+0.06%) :arrow_up:
test/objects/minimal.hpp 82.14% <0.00%> (-1.20%) :arrow_down:
test/objects/test.hpp 94.28% <0.00%> (-0.48%) :arrow_down:
include/boost/unordered/unordered_map.hpp 99.84% <0.00%> (-0.01%) :arrow_down:
include/boost/unordered/unordered_set.hpp 98.91% <0.00%> (ø)
test/unordered/emplace_tests.cpp 96.82% <0.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ed2a0a...90b2536. Read the comment docs.