boostorg / unordered

Boost.org unordered module
http://boost.org/libs/unordered
Boost Software License 1.0
62 stars 55 forks source link

cxx03 deprecation #215

Closed cmazakas closed 1 year ago

cmazakas commented 1 year ago

Finally remove C++11 polyfills

We remove the dependency on Boost.Tuple but indirectly support it by secretly supporting any generic tuple-type so long as it mimics std::tuple.

The boostdep report before is:

Brief dependency report for unordered (sources on, tests off):

# Primary dependencies

assert
config
container_hash
core
move
mp11
predef
preprocessor
static_assert
throw_exception
tuple
type_traits

# Secondary dependencies

describe

with this change, we see:

Brief dependency report for unordered (sources on, tests off):

# Primary dependencies

assert
config
container_hash
core
mp11
predef
throw_exception

# Secondary dependencies

describe
type_traits
static_assert

In total, this only removes the following dependencies from the project:

with the potential to eventually see both TypeTraits and StaticAssert removed in the future.

codecov[bot] commented 1 year ago

Codecov Report

Merging #215 (554ce65) into develop (6b65c8f) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/boostorg/unordered/pull/215/graphs/tree.svg?width=650&height=150&src=pr&token=ZqRPZlJZ5N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #215 +/- ## =========================================== - Coverage 98.14% 98.12% -0.02% =========================================== Files 141 142 +1 Lines 19518 19502 -16 =========================================== - Hits 19156 19137 -19 - Misses 362 365 +3 ``` | [Files](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) | Coverage Δ | | |---|---|---| | [include/boost/unordered/concurrent\_flat\_map.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvY29uY3VycmVudF9mbGF0X21hcC5ocHA=) | `100.00% <ø> (ø)` | | | [include/boost/unordered/concurrent\_flat\_set.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvY29uY3VycmVudF9mbGF0X3NldC5ocHA=) | `100.00% <ø> (ø)` | | | [...ude/boost/unordered/detail/archive\_constructed.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2FyY2hpdmVfY29uc3RydWN0ZWQuaHBw) | `75.00% <100.00%> (+2.27%)` | :arrow_up: | | [include/boost/unordered/detail/fca.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2ZjYS5ocHA=) | `99.30% <100.00%> (-0.36%)` | :arrow_down: | | [...de/boost/unordered/detail/foa/concurrent\_table.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2ZvYS9jb25jdXJyZW50X3RhYmxlLmhwcA==) | `99.66% <100.00%> (ø)` | | | [include/boost/unordered/detail/foa/core.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2ZvYS9jb3JlLmhwcA==) | `100.00% <100.00%> (ø)` | | | [include/boost/unordered/detail/foa/node\_handle.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2ZvYS9ub2RlX2hhbmRsZS5ocHA=) | `92.75% <ø> (-0.21%)` | :arrow_down: | | [include/boost/unordered/detail/foa/table.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2ZvYS90YWJsZS5ocHA=) | `100.00% <100.00%> (ø)` | | | [include/boost/unordered/detail/implementation.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL2ltcGxlbWVudGF0aW9uLmhwcA==) | `99.22% <100.00%> (-0.01%)` | :arrow_down: | | [include/boost/unordered/detail/narrow\_cast.hpp](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91bm9yZGVyZWQvZGV0YWlsL25hcnJvd19jYXN0LmhwcA==) | `100.00% <100.00%> (ø)` | | | ... and [39 more](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/boostorg/unordered/pull/215/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [6b65c8f...554ce65](https://app.codecov.io/gh/boostorg/unordered/pull/215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).
joaquintides commented 1 year ago

Before I forget, libraries.json need be updated to "cxxstd": "11". It's a good opportunity to update the maintainers info, also.

pdimov commented 1 year ago

The maintainer info should be updated immediately; no need to wait for this branch. :-)