boostorg / url

Boost.URL is a library for manipulating Uniform Resource Identifiers (URIs) and Locators (URLs).
https://www.boost.org/doc/libs/master/libs/url/doc/html/index.html
Boost Software License 1.0
185 stars 49 forks source link

refactor: unsafe encoding assumes default options #831

Closed alandefreitas closed 6 months ago

alandefreitas commented 6 months ago

The private unsafe encoding functions received a parameter to determine the encoding options. However, these functions are never used in any context where these options should diverge from the default values.

This is a partial solution to https://github.com/boostorg/url/issues/828, where detail/encode.hpp is the file with the lowest coverage.

cppalliance-bot commented 6 months ago

GCOVR code coverage report https://831.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://831.url.prtest2.cppalliance.org/genhtml/index.html Coverage Diff https://831.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.59%. Comparing base (6ec189b) to head (a1a5760).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/boostorg/url/pull/831/graphs/tree.svg?width=650&height=150&src=pr&token=XroexNAcpL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://app.codecov.io/gh/boostorg/url/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #831 +/- ## =========================================== + Coverage 98.27% 98.59% +0.31% =========================================== Files 157 157 Lines 8513 8453 -60 =========================================== - Hits 8366 8334 -32 + Misses 147 119 -28 ``` | [Files](https://app.codecov.io/gh/boostorg/url/pull/831?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) | Coverage Δ | | |---|---|---| | [include/boost/url/detail/encode.hpp](https://app.codecov.io/gh/boostorg/url/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC91cmwvZGV0YWlsL2VuY29kZS5ocHA=) | `100.00% <100.00%> (+35.89%)` | :arrow_up: | | [src/detail/any\_params\_iter.cpp](https://app.codecov.io/gh/boostorg/url/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-c3JjL2RldGFpbC9hbnlfcGFyYW1zX2l0ZXIuY3Bw) | `99.40% <100.00%> (-0.05%)` | :arrow_down: | | [src/detail/any\_segments\_iter.cpp](https://app.codecov.io/gh/boostorg/url/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-c3JjL2RldGFpbC9hbnlfc2VnbWVudHNfaXRlci5jcHA=) | `100.00% <ø> (ø)` | | | [src/url\_base.cpp](https://app.codecov.io/gh/boostorg/url/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-c3JjL3VybF9iYXNlLmNwcA==) | `99.63% <100.00%> (-0.01%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/boostorg/url/pull/831?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/boostorg/url/pull/831?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [6ec189b...a1a5760](https://app.codecov.io/gh/boostorg/url/pull/831?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).
cppalliance-bot commented 6 months ago

GCOVR code coverage report https://831.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://831.url.prtest2.cppalliance.org/genhtml/index.html Coverage Diff https://831.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 6 months ago

GCOVR code coverage report https://831.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://831.url.prtest2.cppalliance.org/genhtml/index.html Coverage Diff https://831.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 6 months ago

GCOVR code coverage report https://831.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://831.url.prtest2.cppalliance.org/genhtml/index.html Coverage Diff https://831.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

cppalliance-bot commented 6 months ago

GCOVR code coverage report https://831.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://831.url.prtest2.cppalliance.org/genhtml/index.html Coverage Diff https://831.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt