Convert all checks for whether pData_ points to emptyString_ to checks for zero capacity(). This is a safer check, which should work across shared library boundaries.
Removes AllocatorStringStorage::Realloc. This function was not used and potentially incorrect, as it would call Free on the input buffer, even if it was emptyString_.
I did not use #pragma to silence the warnings because it seems gcc 11.2 doesn't support disabling this warning (the warnings are still emitted).
This PR makes 3 commits:
pData_points toemptyString_to checks for zerocapacity(). This is a safer check, which should work across shared library boundaries.pData_never points toemptyString_whencapacity()is zero. This fixes https://github.com/boostorg/wave/issues/159.AllocatorStringStorage::Realloc. This function was not used and potentially incorrect, as it would callFreeon the input buffer, even if it wasemptyString_.I did not use
#pragmato silence the warnings because it seems gcc 11.2 doesn't support disabling this warning (the warnings are still emitted).