search

boostorg / wave

Boost.org wave module
http://boost.org/libs/wave
21 stars 49 forks source link

Use constexpr instead of macros for tokenid constants in samples #167

Closed jefftrull closed 2 years ago

jefftrull commented 2 years ago

Under Visual Studio 2019 (and possibly earlier), building with /permissive- causes three samples to fail to compile. Adding the /Zc:twoPhase- option makes them compile successfully again. See bug #160 for more details.

It's unclear what the source of this issue is, but using constexpr variables instead of a macro is better practice anyway, and fixes the errors.

hkaiser commented 2 years ago

Shouldn't we however change all of the token_id definitions (at least for consistency's sake)?

Nvm, I take the last part back.